This repository was archived by the owner on Nov 28, 2018. It is now read-only.
Fix package folder check#20
Open
cuibonobo wants to merge 1 commit intotzulberti:masterfrom
cuibonobo:patch-2
Open
Fix package folder check#20cuibonobo wants to merge 1 commit intotzulberti:masterfrom cuibonobo:patch-2
cuibonobo wants to merge 1 commit intotzulberti:masterfrom
cuibonobo:patch-2
Conversation
The `os.path.exists` function should check `package_folder` instead of `package_name`, otherwise it will always return `False`.
|
why doesn't nobody merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
os.path.existsfunction should checkpackage_folderinstead ofpackage_name, otherwise it will always returnFalse.